Initialise dataset from manifest #911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeorgesLorre
merged commit a4a3eeb
into
feature/refactore-pipeline-interface
9 checks passed
GeorgesLorre
pushed a commit
that referenced
this pull request
Apr 4, 2024
Implements the new workflow including initialising datasets from manifest. - removes workspace again, using working_directory argument now to enable something like `fondant run ... --working_directory gs://...` - removes base_path from the manifest and changes the field location to absolute paths - changes the executor to generate absolute field locations - add `Dataset.read()` for initialising dataset from manifest path - adjust compiler code Try to create sketch out the flow and changes. Still have to fix the test cases and test the changes end to end for all runners. 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the new workflow including initialising datasets from manifest.
fondant run ... --working_directory gs://...Dataset.read()for initialising dataset from manifest pathTry to create sketch out the flow and changes. Still have to fix the test cases and test the changes end to end for all runners.